-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CS config by default too #5467
Conversation
d1d7df5
to
761aed9
Compare
@keradus can this be merged and which branch to target? |
@mvorisek what about this comment: #5467 (comment) ? |
899d961
to
ae64592
Compare
25b8d26
to
929c77c
Compare
33f033a
to
0140ba9
Compare
Both comments are now addressed, is everyone happy now? :) |
fabbot isn't 😉 |
227256b
to
90feea6
Compare
This reverts commit 342d09c.
@kubawerlos I tried to please this bot too with 342d09c, but if I follow the bot advise, I get:
from phpstan. Let me know what to do with this, the fabbot error is unrelated, only some unrelated change was done in that file. |
I'm not convinced for this change, myself. I'm thinking about alternatives |
Please tell your concerns. |
I wasn't concerned. I was not convinced. Thanks for all the effort. |
Yes, a lot of work, but new |
fabbot.io
Use ::class whenever possible
should be ignored, otherwise PHPStan is not happy, unrelated with this PR...